Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update find your store address popup illustration #13252

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Update find your store address popup illustration #13252

merged 1 commit into from
Jan 8, 2025
+158 −200

Conversation

irfano
Copy link
Contributor

@irfano irfano commented Jan 7, 2025 •
edited
Loading

Part of: woocommerce/woomobile-private#376

Description

This updates the "Find your store address" popup

Steps to reproduce

  1. Tap the "Log in" button.
  2. Tap the "Find your store address" button

From site picker

  1. Log in.
  2. Go to the site picker screen from the menu.
  3. Tap the CONNECT ANOTHER STORE button.
  4. Tap the Find your site address button.

The tests that have been performed

Steps above

Images/gif

Before After After Dark
  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

@irfano irfano added the category: design Layout and style elements in the UI or user interface, including color and animations. label Jan 7, 2025
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commita2f68d7
Direct Downloadwoocommerce-wear-prototype-build-pr13252-a2f68d7.apk

@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commita2f68d7
Direct Downloadwoocommerce-prototype-build-pr13252-a2f68d7.apk

github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 7, 2025
View reviewed changes
WooCommerce/src/main/res/drawable-night/login_site_address_help.xml Dismissed Show dismissed Hide dismissed
WooCommerce/src/main/res/drawable-night/login_site_address_help.xml
</path>
<path
android:fillColor="#fff"
android:pathData="M96.39,67.41c-0.58,0 -0.99,0.41 -1.03,1.04h2.01c-0.02,-0.63 -0.4,-1.04 -0.98,-1.04ZM97.38,69.82h0.92c-0.18,0.78 -0.89,1.26 -1.9,1.26 -1.26,0 -2.02,-0.83 -2.02,-2.21s0.77,-2.24 2.01,-2.24c1.22,0 1.95,0.81 1.95,2.16v0.31h-2.98v0.05c0.02,0.71 0.43,1.16 1.07,1.16 0.48,0 0.81,-0.17 0.95,-0.49ZM100.49,69.53h-0.07L99.54,71L98.5,71l1.38,-2.12 -1.39,-2.15h1.12l0.85,1.47h0.07l0.84,-1.47h1.07l-1.38,2.11 1.39,2.16h-1.09l-0.88,-1.47ZM104.42,70.31c0.59,0 1.02,-0.38 1.02,-0.88v-0.34l-0.96,0.06c-0.54,0.04 -0.8,0.23 -0.8,0.58 0,0.36 0.31,0.57 0.74,0.57ZM104.13,71.07c-0.82,0 -1.41,-0.5 -1.41,-1.28 0,-0.77 0.58,-1.22 1.62,-1.28l1.1,-0.07v-0.36c0,-0.42 -0.28,-0.65 -0.81,-0.65 -0.44,0 -0.75,0.16 -0.84,0.44h-0.91c0.08,-0.75 0.79,-1.23 1.8,-1.23 1.1,0 1.72,0.54 1.72,1.44L106.39,71h-0.93v-0.59h-0.07c-0.24,0.41 -0.71,0.66 -1.26,0.66ZM107.24,71v-4.27h0.93v0.69h0.07c0.18,-0.49 0.62,-0.78 1.19,-0.78 0.59,0 1,0.3 1.18,0.78h0.07c0.21,-0.47 0.7,-0.78 1.3,-0.78 0.86,0 1.37,0.54 1.37,1.42L113.35,71h-0.96v-2.69c0,-0.55 -0.26,-0.82 -0.78,-0.82 -0.5,0 -0.84,0.37 -0.84,0.86L110.76,71h-0.94v-2.76c0,-0.47 -0.3,-0.75 -0.77,-0.75 -0.48,0 -0.84,0.4 -0.84,0.92L108.21,71h-0.97ZM116.5,66.66c1.08,0 1.76,0.84 1.76,2.21 0,1.36 -0.67,2.21 -1.75,2.21 -0.61,0 -1.09,-0.26 -1.3,-0.72h-0.07v2.07h-0.97v-5.7h0.93v0.71h0.07c0.25,-0.49 0.74,-0.78 1.33,-0.78ZM116.2,70.25c0.67,0 1.07,-0.52 1.07,-1.38s-0.4,-1.38 -1.07,-1.38c-0.66,0 -1.07,0.53 -1.08,1.38 0,0.86 0.41,1.38 1.08,1.38ZM118.96,71v-5.93h0.97L119.92,71h-0.97ZM122.62,67.41c-0.58,0 -0.98,0.41 -1.03,1.04h2.01c-0.02,-0.63 -0.4,-1.04 -0.98,-1.04ZM123.61,69.82h0.92c-0.18,0.78 -0.89,1.26 -1.9,1.26 -1.26,0 -2.02,-0.83 -2.02,-2.21s0.77,-2.24 2.01,-2.24c1.22,0 1.95,0.81 1.95,2.16v0.31h-2.98v0.05c0.02,0.71 0.43,1.16 1.07,1.16 0.48,0 0.81,-0.17 0.95,-0.49ZM125.95,71.08a0.6,0.6 0,0 1,-0.63 -0.62,0.6 0.6,0 0,1 0.63,-0.62c0.37,0 0.63,0.26 0.63,0.62a0.6,0.6 0,0 1,-0.63 0.62ZM131.08,68.16h-0.92c-0.09,-0.41 -0.41,-0.71 -0.94,-0.71 -0.66,0 -1.06,0.51 -1.06,1.4 0,0.9 0.4,1.42 1.06,1.42 0.5,0 0.84,-0.24 0.94,-0.68h0.92c-0.11,0.89 -0.78,1.5 -1.86,1.5 -1.28,0 -2.04,-0.83 -2.04,-2.23 0,-1.39 0.75,-2.21 2.04,-2.21 1.1,0 1.76,0.63 1.86,1.52ZM133.53,71.09c-1.28,0 -2.05,-0.84 -2.05,-2.22 0,-1.38 0.79,-2.22 2.05,-2.22 1.27,0 2.06,0.84 2.06,2.22 0,1.39 -0.78,2.22 -2.06,2.22ZM133.53,70.27c0.68,0 1.06,-0.51 1.06,-1.41 0,-0.89 -0.39,-1.41 -1.06,-1.41 -0.68,0 -1.06,0.52 -1.06,1.41 0,0.89 0.39,1.41 1.06,1.41ZM136.24,71v-4.27h0.93v0.69h0.07c0.18,-0.49 0.62,-0.78 1.19,-0.78 0.59,0 1,0.3 1.18,0.78h0.07c0.21,-0.47 0.7,-0.78 1.3,-0.78 0.86,0 1.37,0.54 1.37,1.42L142.34,71h-0.96v-2.69c0,-0.55 -0.26,-0.82 -0.78,-0.82 -0.5,0 -0.84,0.37 -0.84,0.86L139.76,71h-0.94v-2.76c0,-0.47 -0.3,-0.75 -0.77,-0.75 -0.48,0 -0.84,0.4 -0.84,0.92L137.21,71h-0.97Z" />

Check warning

Code scanning / Android Lint

Long vector paths Warning

Very long vector path (2748 characters), which is bad for performance. Considering reducing precision, removing minor details or rasterizing vector.
WooCommerce/src/main/res/drawable/login_site_address_help.xml Dismissed Show dismissed Hide dismissed
WooCommerce/src/main/res/drawable/login_site_address_help.xml Dismissed Show dismissed Hide dismissed
@codecov-commenter
Copy link

codecov-commenter commented Jan 7, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.59%. Comparing base (86fd85c) to head (a2f68d7).
Report is 308 commits behind head on feature/woo-2.0-brand-updates.

Additional details and impacted files 
@@                       Coverage Diff                        @@
##             feature/woo-2.0-brand-updates   #13252   +/-   ##
================================================================
  Coverage                            40.59%   40.59%           
  Complexity                            6372     6372           
================================================================
  Files                                 1345     1345           
  Lines                                77235    77235           
  Branches                             10602    10602           
================================================================
  Hits                                 31352    31352           
  Misses                               43135    43135           
  Partials                              2748     2748

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hafizrahman hafizrahman self-assigned this Jan 8, 2025
hafizrahman
hafizrahman approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@hafizrahman hafizrahman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, works well both in dark and light mode in my check 💯

@hafizrahman hafizrahman merged commit 3bc342f into feature/woo-2.0-brand-updates Jan 8, 2025
17 checks passed
@hafizrahman hafizrahman deleted the feature/update-find-your-store-address-popup branch January 8, 2025 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hafizrahman hafizrahman hafizrahman approved these changes

@hichamboushaba hichamboushaba Awaiting requested review from hichamboushaba

Assignees

@hafizrahman hafizrahman

Labels
category: design Layout and style elements in the UI or user interface, including color and animations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@irfano @dangermattic @wpmobilebot @codecov-commenter @hafizrahman